It gave them weapons they can’t manufacture themselves and kept them afloat financially despite frankly brutal Western sanctions.

It’s mostly the other way around with Iran manufacturing Shahed drones for Russia and licensing production to them.

Since they’re still able to be a thorn in the West’s side, I’d say they’re doing something right.

Most Gulf states are probably happy that Iran is getting attacked, they just don’t like that it’s Israel doing (and possibly benefiting from) it. Realistically, Iran has no allies, only business partners.

I don’t think anyone is expecting Russia to go to war on their behalf, but a more or less reliable non-Western trade and defense partner is a pretty attractive proposition.

Not in the Iran case, but CSTO is such an agreement that nobody honored, which is why Armenia froze its membership. Also Russia is years behind on their agreed weapon sales because of their own huge demand in Ukraine.